PATCH: use fb instead of mfb+cfb

[Kristian Høgsberg]

So, I didn't get much response on this... am I posting to the wrong 
list, is there a devel-list?

I think the patch is pretty harmless, and it does fix a real bug in 
vncserver.  It defaults to the cfb setup, but allows users that have 
problems with cfb or that wants to test fb to do that.

It's a good way to get some testing on the fb solution, while still 
having a fallback to the old code.

Is there any reason this can not be added to the vnc package?

Thanks,
Kristian

Kristian HC8gsberg wrote:
> Hi,
> 
> I've been chasing a bug with vnc-4.0, where eclipse (3.0) crashes the
> server. The crash seems to be related to selections and the red wiggly
> lines under syntax errors. It is pretty easy to reproduce and
> searching the vnc-list archives returns a number of similiar reports. I
> suspect that the error is somewhere in XDrawLines() e.g.
> Xserver/cfb/cfb8line.c.
> 
> Now, I tried to debug cfb8line.c a bit, but that code is very hard to
> work with, e.g. almost one third of 1500 lines is cryptic C preprocessor
> code. Instead I decided to try to change Xvnc to use the fb layer
> instead. The fb code is meant to be a modern, maintainable drop-in
> replacement for the cfb and mfb layers, and the change was not too
> difficult to implement. I've attached the patch that does this. The
> X.org project is moving to deprecate the cfb and mfb layers and at this
> point almost no servers in the X.org tree use them.
> 
> The patch is against the 4.0 release and adds a configure option,
> --with-fb, which will compile Xvnc against the fb layer. The existing
> cfb is still in place and preserved as the default choice. To reflect
> the autoconf'ed fb choice into the X servers Imake system, I've moved
> config/cf/vnc.def to config/cf/vnc.def.in so that configure can subst
> VNC_USE_FB into that file. After the patch is applied tarball, configure
> should be regenerated by running autoconf.
> 
> The patch is at http://people.redhat.com/krh/vnc/vnc-use-fb.patch.
> 
> Kristian
> _______________________________________________
> VNC-List mailing list
> VNC-List "at" realvnc.com
> To remove yourself from the list visit:
> http://www.realvnc.com/mailman/listinfo/vnc-list