Unix 3.3.3

[Tristan Richardson]

"Ellis Golub" <ellis "at" vesicle.dental.upenn.edu> writes:

> Hi --
> 
> I've got WinVNC 3.3.3R1 running under NT4 SP5 as a service, and I just compiled
> vncviewer 3.3.3 on my SGI Indigo^2 running IRIX 6.2.  Everything is *much*
> faster and seems to work great.  Congratulations!!
> 
> My only problem so far is that pressing F8 crashes the viewer with the
> following error message:
> 
> CleanupXErrorHandler called
> X Error of failed request:  BadMatch (invalid parameter attributes)
>   Major opcode of failed request:  1 (X_CreateWindow)
>   Serial number of failed request:  2658359
>   Current serial number in output stream:  2658379
> 
> I'm prepared to tinker, but I need some clues.
> 


I suspect this is a bug in vncviewer to do with visuals and colormaps.
Basically the popup window tries to use the same visual and colormap as the
main viewer window when it should really use the default visual and colormap
for the display.

If this is the problem there's a very simple fix, which is simply to swap the
calls to SetVisualAndCmap() and CreatePopup() in "vncviewer.c" - here's a diff:


diff -c -r1.2 vncviewer.c
*** vncviewer.c 1999/08/13 10:18:38     1.2
--- vncviewer.c 1999/09/17 14:41:30
***************
*** 80,93 ****
  
    if (!InitialiseRFBConnection()) exit(1);
  
-   /* Find the best pixel format and X visual/colormap to use */
- 
-   SetVisualAndCmap();
- 
    /* Create the "popup" widget - this won't actually appear on the screen until
       some user-defined event causes the "ShowPopup" action to be invoked */
  
    CreatePopup();
  
    /* Create the "desktop" widget, and perform initialisation which needs doing
       before the widgets are realized */
--- 80,93 ----
  
    if (!InitialiseRFBConnection()) exit(1);
  
    /* Create the "popup" widget - this won't actually appear on the screen until
       some user-defined event causes the "ShowPopup" action to be invoked */
  
    CreatePopup();
+ 
+   /* Find the best pixel format and X visual/colormap to use */
+ 
+   SetVisualAndCmap();
  
    /* Create the "desktop" widget, and perform initialisation which needs doing
       before the widgets are realized */




We'll incorporate this in the next release, whenever that may be :-)

Cheers

Tristan

---------------------------------------------------------------------------
Tristan Richardson   tjr "at" uk.research.att.com   www.uk.research.att.com/~tjr
---------------------------------------------------------------------------
AT&T Laboratories Cambridge, 24a Trumpington Street, Cambridge, CB2 1QA, UK
Tel: +44 1223 343000      Fax: +44 1223 313542      www.uk.research.att.com
---------------------------------------------------------------------------

---------------------------------------------------------------------
The VNC mailing list - see http://www.uk.research.att.com/vnc/intouch.html
---------------------------------------------------------------------